Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow all default config to be replaced by user config #742

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

06kellyjac
Copy link
Contributor

Currently most config options can be replaced, this change adjusts the rest
to also allow for this.

Currently most config options can be replaced, this change adjusts the rest
to also allow for this.
@github-actions github-actions bot added the fix label Oct 7, 2024
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit fea02a8
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6703edc78c43e30008171bb2
😎 Deploy Preview https://deploy-preview-742--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.34%. Comparing base (890997b) to head (fea02a8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/config/index.js 71.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   57.39%   57.34%   -0.06%     
==========================================
  Files          46       46              
  Lines        1582     1594      +12     
==========================================
+ Hits          908      914       +6     
- Misses        674      680       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit af49ea1 into finos:main Oct 7, 2024
14 checks passed
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants