fix: selectively disable TLS #781
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@YongNotYoung - great PR 👍 Are you able to sign the CLA via EasyCLA and we can get this merged? |
src/config/index.js
Outdated
There was a problem hiding this comment.
Looks like there has been a bit of a merge conflict on this file. We want to ensure we keep everything plugins related 👍
There was a problem hiding this comment.
LGTM! 🍰 Just need to resolve the merge conflict in src/config/index.js.
@coopernetes - would be good to get your eyes on this as well.
Hey @JamieSlome, thanks for the review We need to sort out some admin stuff before we'll be able to sign the CLA, but once we get it done, we'll be able to sign it and push the fixes for the merge conflicts |
proxy.config.json
Outdated
| @@ -97,5 +97,9 @@ | |||
| "urlShortener": "", | |||
| "contactEmail": "", | |||
| "csrfProtection": true, | |||
| "plugins": [] | |||
| "tls": { | |||
| "enabled": false, | |||
There was a problem hiding this comment.
| "enabled": false, | |
| "enabled": true, |
For the purposes of a good (and secure!) default experience, let's keep TLS enabled by default since there's already self-signed certs shipped with the repo.
closes #658