Add constraints for protocol java generation #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflow Telemetry - Build CI / BuildWorkflow telemetry for commit 4870eba33be8bfb836d55fb2b444558f5419035d Step Tracegantt
title Build
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1727193609000, 1727193612000
Checkout repo : 1727193612000, 1727193616000
Cache Maven dependencies : 1727193616000, 1727193655000
Set up JDK : 1727193655000, 1727193681000
Check Java version : 1727193681000, 1727193681000
Configure git : 1727193681000, 1727193681000
Download deps and plugins : 1727193681000, 1727193708000
Collect Workflow Telemetry : 1727193708000, 1727193708000
CPU MetricsMemory MetricsIO Metrics
Process TraceTop 100 processes with highest durationgantt
title Build
dateFormat x
axisFormat %H:%M:%S
|
Workflow Telemetry - Build CI / BuildWorkflow telemetry for commit 5e54629ddc482d920b1fc561e41ff7e6b41c2af8 Step Tracegantt
title Build
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1727194265000, 1727194267000
Checkout repo : 1727194267000, 1727194271000
Cache Maven dependencies : 1727194271000, 1727194310000
Set up JDK : 1727194310000, 1727194336000
Check Java version : 1727194336000, 1727194336000
Configure git : 1727194336000, 1727194336000
Download deps and plugins : 1727194336000, 1727194355000
Collect Workflow Telemetry : 1727194355000, 1727194355000
Build (PR) : 1727194355000, 1727199424000
Build (with Maven Deploy + Docker Snapshot) : done, 1727199424000, 1727199424000
Test : 1727199424000, 1727205048000
Upload Test Results : 1727205048000, 1727205079000
CPU MetricsMemory MetricsIO Metrics
Process TraceTop 100 processes with highest durationgantt
title Build
dateFormat x
axisFormat %H:%M:%S
|
epsstan
approved these changes
Sep 24, 2024
Workflow Telemetry - Build CI / BuildWorkflow telemetry for commit a1accd99fae34b0c74321c1f09702cc98dd3ea11 Step Tracegantt
title Build
dateFormat x
axisFormat %H:%M:%S
Set up job : milestone, 1727213230000, 1727213232000
Checkout repo : 1727213232000, 1727213237000
Cache Maven dependencies : 1727213237000, 1727213278000
Set up JDK : 1727213278000, 1727213302000
Check Java version : 1727213302000, 1727213302000
Configure git : 1727213302000, 1727213302000
Download deps and plugins : 1727213302000, 1727213327000
Collect Workflow Telemetry : 1727213327000, 1727213327000
Build (PR) : 1727213327000, 1727218373000
Build (with Maven Deploy + Docker Snapshot) : done, 1727218373000, 1727218373000
Test : 1727218373000, 1727223892000
CPU MetricsMemory MetricsIO Metrics
Process TraceTop 100 processes with highest durationgantt
title Build
dateFormat x
axisFormat %H:%M:%S
|
AFine-gs
pushed a commit
to AFine-gs/legend-engine
that referenced
this pull request
Sep 27, 2024
* Add constraint validation for Protocol Java generation * Add tests for Enum constraints * Always Box primitives * Fix boolean type * Fix tests * Add default to Protocol * Fix validation * Fix impacted tests * Fix one validation edge case * Flip test for constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add constraints for protocol java generation