Studio persistence v2 spec #2404

ankitamritraj · 2023-07-05T15:35:30Z

Summary

How did you test this change?

Test(s) added
Manual testing (please provide screenshots/recordings)
No testing (please provide an explanation)

legend-studio-test.mp4

changeset-bot · 2023-07-05T15:35:35Z

🦋 Changeset detected

Latest commit: 64acce1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@finos/legend-extension-dsl-persistence	Patch
@finos/legend-application-query-bootstrap	Patch
@finos/legend-application-studio-bootstrap	Patch
@finos/legend-manual-tests	Patch
@finos/legend-application-query-deployment	Patch
@finos/legend-application-studio-deployment	Patch
@finos/legend-application-pure-ide-deployment	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

linux-foundation-easycla · 2023-07-05T15:35:37Z

The committers listed above are authorized under a signed CLA.

✅ login: ankitamritraj / name: Ankit Amrit Raj (21af40a, 4ed4e0c, 9d1a3d4, 828e390, 6c4311b, 8441fa0, 1d4c64a, dbde01c, 61d582a, 73e3ad8, 6f93962, 64acce1)

Added persistence unitemporal/bitmporal spec tests

gayathrir11

Please add some unit tests here: packages\legend-extension-dsl-persistence\src\graph-manager_tests_\DSL_Persistence_Roundtrip.test.ts

gayathrir11 · 2023-07-07T05:46:14Z

...ol/pure/v1/model/packageableElements/persistence/V1_DSL_Persistence_ActionIndicatorFields.ts

@@ -0,0 +1,51 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs


Please add a changeset. Check this for details: https://github.com/finos/legend-studio/blob/master/CONTRIBUTING.md#changeset

gayathrir11 · 2023-07-07T05:49:11Z

...ger/protocol/pure/v1/model/packageableElements/persistence/V1_DSL_Persistence_Persistence.ts


 export class V1_Persistence extends V1_PackageableElement implements Hashable {
 documentation!: string;
 trigger!: V1_Trigger;
 service!: string;
- persister!: V1_Persister;
+ persister: V1_Persister | undefined;


Please modify this to:
persister?: V1_Persister | undefined;

gayathrir11 · 2023-07-07T05:49:40Z

...ger/protocol/pure/v1/model/packageableElements/persistence/V1_DSL_Persistence_Persistence.ts


 export class V1_Persistence extends V1_PackageableElement implements Hashable {
 documentation!: string;
 trigger!: V1_Trigger;
 service!: string;
- persister!: V1_Persister;
+ persister: V1_Persister | undefined;
+ serviceOutputTargets: V1_ServiceOutputTarget[] | undefined;


Please modify this to:
serviceOutputTargets?: V1_ServiceOutputTarget[] | undefined;

gayathrir11 · 2023-07-07T05:50:33Z

...ger/protocol/pure/v1/model/packageableElements/persistence/V1_DSL_Persistence_Persistence.ts

@@ -39,7 +41,8 @@ export class V1_Persistence extends V1_PackageableElement implements Hashable {
 this.documentation,
 this.trigger,
 this.service,
- this.persister,
+ hashArray(this.serviceOutputTargets ?? []),


Please modify this to:
this.serviceOutputTargets ? hashArray(this.serviceOutputTargets) : '',

As discussed keeping it as empty array [].

gayathrir11 · 2023-07-07T09:32:21Z

...ph-manager/protocol/pure/v1/transformation/pureProtocol/V1_DSL_Persistence_ProtocolHelper.ts

+ (val) => V1_serializeServiceOutput(val, plugins),
+ (val) => V1_deserializeServiceOutput(val, plugins),
+ ),
+ persistenceTarget: custom(


Can you rearrange them in alphabetical order

gayathrir11 · 2023-07-07T09:46:04Z

...rc/graph/metamodel/pure/model/packageableElements/persistence/DSL_Persistence_Persistence.ts

@@ -35,7 +36,8 @@ export class Persistence
 documentation!: string;
 trigger!: Trigger;
 service!: PackageableElementReference<Service>;
- persister!: Persister;
+ persister: Persister | undefined;


Please modify this to
persister?: Persister | undefined;

gayathrir11 · 2023-07-07T09:46:33Z

...rc/graph/metamodel/pure/model/packageableElements/persistence/DSL_Persistence_Persistence.ts

@@ -45,7 +47,8 @@ export class Persistence
 this.documentation,
 this.trigger,
 this.service.valueForSerialization ?? '',
- this.persister,
+ hashArray(this.serviceOutputTargets ?? []),


Please make the similar modification as mentioned in protocol model

As discussed keeping it as empty array [].

codecov · 2023-07-10T07:39:29Z

Codecov Report

Merging #2404 (8441fa0) into master (27bef82) will decrease coverage by 0.14%.
The diff coverage is 29.68%.

❗ Current head 8441fa0 differs from pull request most recent head 64acce1. Consider uploading reports for the commit 64acce1 to get more accurate results

@@            Coverage Diff             @@
##           master    #2404      +/-   ##
==========================================
- Coverage   40.91%   40.78%   -0.14%     
==========================================
  Files        1561     1591      +30     
  Lines       73857    74731     +874     
  Branches    17375    17524     +149     
==========================================
+ Hits        30222    30480     +258     
- Misses      43511    44127     +616     
  Partials      124      124

Impacted Files	Coverage Δ
...stence/V1_DSL_Persistence_ActionIndicatorFields.ts	`0.00% <0.00%> (ø)`
...s/persistence/V1_DSL_Persistence_AppendStrategy.ts	`0.00% <0.00%> (ø)`
...ments/persistence/V1_DSL_Persistence_AuditingV2.ts	`0.00% <0.00%> (ø)`
...ents/persistence/V1_DSL_Persistence_DatasetType.ts	`0.00% <0.00%> (ø)`
...ts/persistence/V1_DSL_Persistence_Deduplication.ts	`0.00% <0.00%> (ø)`
...istence/V1_DSL_Persistence_EmptyDatasetHandling.ts	`0.00% <0.00%> (ø)`
...nts/persistence/V1_DSL_Persistence_Partitioning.ts	`0.00% <0.00%> (ø)`
...persistence/V1_DSL_Persistence_PersistentTarget.ts	`0.00% <0.00%> (ø)`
...sistence/V1_DSL_Persistence_ProcessingDimension.ts	`0.00% <0.00%> (ø)`
...ts/persistence/V1_DSL_Persistence_ServiceOutput.ts	`0.00% <0.00%> (ø)`
... and 25 more

…ed-engine spec finos/legend-engine#1998

gayathrir11 · 2023-07-11T06:13:35Z

.changeset/lemon-zebras-talk.md

@@ -0,0 +1,4 @@
+---
+---


You don't need this. Can you remove this?

MauricioUyaguari · 2023-07-11T13:16:47Z

...legend-manual-tests/src/__tests__/roundtrip-grammar/cases/DSL_PersistenceV2-unitemporal.pure

+ ];
+ }
+ tests:
+ [


could we have one of the tests have test grammar ? In the video we have a nice grammar with tests as well, can't we use that :)

Sure. I've added!

ankitamritraj · 2023-07-12T05:16:23Z

/easycla

re-reviewed

ankitamritraj added 5 commits July 4, 2023 13:24

Initial commit

21af40a

initial commit

4ed4e0c

Added persistence V2 spec

9d1a3d4

Merge branch 'finos:master' into ankit-persistence-v2-spec

828e390

Minor fixes + Added studio round trip test

6c4311b

ankitamritraj requested a review from a team as a code owner July 5, 2023 15:35

Added persistence v2 unitemporal/bitemporal spec tests

8441fa0

Added persistence unitemporal/bitmporal spec tests

gayathrir11 requested changes Jul 7, 2023

View reviewed changes

Refactoring + Added roundtrip tests

1d4c64a

ankitamritraj added 3 commits July 10, 2023 13:28

Create lemon-zebras-talk.md

dbde01c

Create modern-adults-play.md

61d582a

Updated _type for SourceTimeFields and AppendStrategy per latest leng…

73e3ad8

…ed-engine spec finos/legend-engine#1998

gayathrir11 reviewed Jul 11, 2023

View reviewed changes

Deleted redundant changeset file

6f93962

MauricioUyaguari previously requested changes Jul 11, 2023

View reviewed changes

lint fixes + added tests for persistent test spec

64acce1

ankitamritraj requested a review from MauricioUyaguari July 11, 2023 21:25

akphi approved these changes Jul 13, 2023

View reviewed changes

akphi merged commit 757f5ae into finos:master Jul 13, 2023
7 of 10 checks passed

github-actions bot mentioned this pull request Jul 13, 2023

Iteration Release v9.69.0 #2429

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Studio persistence v2 spec #2404

Studio persistence v2 spec #2404

ankitamritraj commented Jul 5, 2023 •

edited

Loading

changeset-bot bot commented Jul 5, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jul 5, 2023 •

edited

Loading

gayathrir11 left a comment

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

gayathrir11 Jul 7, 2023

ankitamritraj Jul 10, 2023

codecov bot commented Jul 10, 2023 •

edited

Loading

gayathrir11 Jul 11, 2023

ankitamritraj Jul 11, 2023

MauricioUyaguari Jul 11, 2023 •

edited

Loading

ankitamritraj Jul 11, 2023

ankitamritraj commented Jul 12, 2023

		@@ -0,0 +1,51 @@
		/**
		* Copyright (c) 2020-present, Goldman Sachs

		@@ -0,0 +1,4 @@
		---
		---

Studio persistence v2 spec #2404

Studio persistence v2 spec #2404

Conversation

ankitamritraj commented Jul 5, 2023 • edited Loading

Summary

How did you test this change?

changeset-bot bot commented Jul 5, 2023 • edited Loading

🦋 Changeset detected

linux-foundation-easycla bot commented Jul 5, 2023 • edited Loading

gayathrir11 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 10, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MauricioUyaguari Jul 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitamritraj commented Jul 12, 2023

ankitamritraj commented Jul 5, 2023 •

edited

Loading

changeset-bot bot commented Jul 5, 2023 •

edited

Loading

linux-foundation-easycla bot commented Jul 5, 2023 •

edited

Loading

codecov bot commented Jul 10, 2023 •

edited

Loading

MauricioUyaguari Jul 11, 2023 •

edited

Loading