-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Mastery Precedence rules #2427
Conversation
🦋 Changeset detectedLatest commit: 689046a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
af54c4b
to
42228eb
Compare
'@finos/legend-application-studio-bootstrap': patch | ||
--- | ||
|
||
Support for Mastery Precedence rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need changeset message for these modules.
I think you missed the only relevant changeset which is "@finos/legend-extension-dsl-mastery"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had used the command 'yarn changeset' to generate the changeset. Do you still want me to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah please change it - and also fix the code check error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Both comments have now been addresseed.
Codecov Report
@@ Coverage Diff @@
## master #2427 +/- ##
==========================================
+ Coverage 41.29% 41.82% +0.52%
==========================================
Files 1544 1581 +37
Lines 73191 74430 +1239
Branches 17296 17513 +217
==========================================
+ Hits 30224 31130 +906
- Misses 42842 43174 +332
- Partials 125 126 +1
|
42228eb
to
689046a
Compare
Summary
The PR represents the studio changes for a new mastery precedence rules that had been recently added to engine(finos/legend-engine#1985). It allows users of mastery to define extra rules around the curation of their master records.
How did you test this change?