Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Mastery Precedence rules #2427

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

Oluwatobiadeoye
Copy link
Contributor

@Oluwatobiadeoye Oluwatobiadeoye commented Jul 12, 2023

Summary

The PR represents the studio changes for a new mastery precedence rules that had been recently added to engine(finos/legend-engine#1985). It allows users of mastery to define extra rules around the curation of their master records.

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
    image
  • No testing (please provide an explanation)

@Oluwatobiadeoye Oluwatobiadeoye requested a review from a team as a code owner July 12, 2023 17:00
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: 689046a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@finos/legend-extension-dsl-mastery Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

'@finos/legend-application-studio-bootstrap': patch
---

Support for Mastery Precedence rules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need changeset message for these modules.
I think you missed the only relevant changeset which is "@finos/legend-extension-dsl-mastery"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had used the command 'yarn changeset' to generate the changeset. Do you still want me to change it?

Copy link
Contributor

@akphi akphi Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah please change it - and also fix the code check error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Both comments have now been addresseed.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2427 (689046a) into master (aaf62ce) will increase coverage by 0.52%.
The diff coverage is 94.39%.

@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
+ Coverage   41.29%   41.82%   +0.52%     
==========================================
  Files        1544     1581      +37     
  Lines       73191    74430    +1239     
  Branches    17296    17513     +217     
==========================================
+ Hits        30224    31130     +906     
- Misses      42842    43174     +332     
- Partials      125      126       +1     
Impacted Files Coverage Δ
...tion/changeDetection/DSL_Mastery_ObserverHelper.ts 20.00% <ø> (ø)
...ol/pure/DSL_Mastery_PureProtocolProcessorPlugin.ts 87.87% <85.71%> (-1.60%) ⬇️
...tion/pureProtocol/V1_DSL_Mastery_ProtocolHelper.ts 92.77% <91.17%> (-7.23%) ⬇️
...ation/pureGraph/to/V1_DSL_Mastery_BuilderHelper.ts 96.94% <95.34%> (-3.06%) ⬇️
...pureGraph/from/V1_DSL_Mastery_TransformerHelper.ts 97.18% <95.69%> (-2.82%) ⬇️
...s/mastery/V1_DSL_Mastery_MasterRecordDefinition.ts 100.00% <100.00%> (ø)
...eElements/mastery/V1_DSL_Mastery_PrecedenceRule.ts 100.00% <100.00%> (ø)
...bleElements/mastery/V1_DSL_Mastery_PropertyPath.ts 100.00% <100.00%> (ø)
...geableElements/mastery/V1_DSL_Mastery_RuleScope.ts 100.00% <100.00%> (ø)
...ents/mastery/DSL_Mastery_MasterRecordDefinition.ts 100.00% <100.00%> (ø)
... and 3 more

... and 48 files with indirect coverage changes

@akphi akphi merged commit 58e87d5 into finos:master Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants