Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #883

Merged
merged 9 commits into from
Feb 24, 2022
Merged

minor fixes #883

merged 9 commits into from
Feb 24, 2022

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Feb 24, 2022

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

🦋 Changeset detected

Latest commit: 8ce1045

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@finos/eslint-plugin-legend-studio Patch
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-dev-utils Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-graph Patch
@finos/legend-query Patch
@finos/legend-query-app Patch
@finos/legend-studio Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy Patch
@finos/legend-taxonomy-app Patch
@finos/stylelint-config-legend-studio Patch
@finos/legend-manual-tests Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-model-storage Patch
@finos/legend-query-deployment Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch
@finos/legend-tracer-extension-zipkin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #883 (8ce1045) into master (6bae7e0) will decrease coverage by 0.01%.
The diff coverage is 42.62%.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   42.60%   42.59%   -0.02%     
==========================================
  Files         937      937              
  Lines       42214    42224      +10     
  Branches     9738     9739       +1     
==========================================
  Hits        17986    17986              
- Misses      24157    24167      +10     
  Partials       71       71              
Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/recommended.js 0.00% <ø> (ø)
...-dsl-data-space/src/components/DataSpaceViewer.tsx 7.25% <0.00%> (ø)
...sl-diagram/src/components/studio/DiagramEditor.tsx 11.35% <0.00%> (ø)
...ure/packageableElements/mapping/PropertyMapping.ts 84.61% <ø> (ø)
...e/packageableElements/mapping/SetImplementation.ts 37.03% <0.00%> (-6.45%) ⬇️
...sformation/pureGraph/from/V1_MappingTransformer.ts 80.96% <0.00%> (-0.35%) ⬇️
...to/V1_ProtocolToMetaModelGraphSecondPassBuilder.ts 92.68% <ø> (ø)
.../to/V1_ProtocolToMetaModelGraphThirdPassBuilder.ts 63.63% <ø> (ø)
...query/src/components/QueryBuilderExplorerPanel.tsx 65.18% <0.00%> (+0.28%) ⬆️
...d-query/src/components/QueryBuilderFilterPanel.tsx 57.74% <0.00%> (ø)
... and 21 more

@akphi akphi marked this pull request as ready for review February 24, 2022 23:04
@akphi akphi requested a review from pierredebelen as a code owner February 24, 2022 23:04
@akphi akphi changed the title bug fixes minor fixes Feb 24, 2022
@akphi akphi merged commit 05e5401 into finos:master Feb 24, 2022
@akphi akphi deleted the carla branch February 24, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Mismatch in Studio and Engine handling of unresolved class mapping ID
2 participants