Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape esbuild plugin's symbol replacement. #2807

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Escape esbuild plugin's symbol replacement. #2807

merged 1 commit into from
Oct 28, 2024

Conversation

timbess
Copy link
Contributor

@timbess timbess commented Oct 28, 2024

Minification sometimes adds $ to variable names causing it to be interpreted as regex rather than literally.

@timbess
Escape esbuild plugin's symbol replacement.
59aa070 
Signed-off-by: Timothy Bess <tim@prospective.dev>
@timbess timbess force-pushed the bugfix/fix-esbuild-symbol-escaping branch from 6d2e8af to 59aa070 Compare October 28, 2024 15:22
@timbess timbess marked this pull request as ready for review October 28, 2024 16:46
texodus
texodus approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit e6e6eae into finos:master Oct 28, 2024
12 checks passed
@texodus texodus added the bug Concrete, reproducible bugs label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timbess @texodus