Fix failed color range update #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Kyei <akyei908@gmail.com>
Signed-off-by: Albert Kyei <akyei908@gmail.com>
Signed-off-by: Albert Kyei <akyei908@gmail.com>
texodus
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #2568. Previously, when editing a number column on the Datagrid, a changed color in the color range component seems to transfer over, without reflecting on the column, to another editable number column if the sidebar is not closed.
This bug occurred due to the component failing to re-render when the props change upon switching from editing one number column to another. The fix ensures this missing re-render occurs now and a test has been implemented to confirm this.