Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Table and View with aliasing to discourage instantiation #2830

Closed
wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Member

#2754 remove the top level Table and View as they are not constructible. However, libraries like pydantic and csp like to have types for type validation, so here we reintroduce them but alias them to types to discourage direct instantiation.

Pull Request Checklist

  • Description which clearly states what problems the PR solves.
  • Description contains a link to the Github Issue, and any relevent
    Discussions, this PR applies to.
  • Include new tests that fail without this PR but passes with it.
  • Include any relevent Documentation changes related to this change.
  • Verify all commits have been signed in accordance with the DCO policy.
  • Reviewed PR commit history to remove unnecessary changes.
  • Make sure your PR passes build, test and lint steps completely.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine added enhancement Feature requests or improvements Python labels Nov 6, 2024
@timkpaine
Copy link
Member Author

going to do pyarrow.Table style with a nice exception for the constructors, then move to perspective.types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant