Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer cast expression function #2842

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

texodus
Copy link
Member

@texodus texodus commented Nov 8, 2024

This PR fixes an integer-underflow bug encountered when calculating sum aggregates over integer columns which had been generated by an expression. See the included test for an example using the Perspective ExprTK integer() cast function.

Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus added the bug Concrete, reproducible bugs label Nov 10, 2024
@texodus texodus marked this pull request as ready for review November 10, 2024 23:37
@texodus texodus merged commit 452bfb0 into master Nov 10, 2024
13 checks passed
@texodus texodus deleted the fix-integer-cast-function branch November 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant