SDK-17 Fixed external LoadBalanced config #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external LoadBalanced was broken or has never worked as expected. This PR is more a patch than a real clean fix, knowing that the DFv2 will provide a real scalable solution "by design".
SymConfig.java
The method
getAgentUrl()
was using fieldthis.agentHost
to compute the full Agent server url. Instead, it has to usethis.getAgentHost()
because this method is overridden inSymLoadBalancedConfig.java
.SymLoadBalancedConfig.java
The way that the method
public String getActualAgentHost()
has been implemented was wrong :It was apparently trying to get LB host from the Agent servers defined in the
config-lb.json
file. Moreover, havingagentServers
empty could have lead to a never-ending recursive loop with de subsequent call togetAgentHost()
...