Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CES-898: Created an API to get message by id along with the disclaimer text #114

Merged
merged 1 commit into from
May 26, 2020
Merged

CES-898: Created an API to get message by id along with the disclaimer text #114

merged 1 commit into from
May 26, 2020

Conversation

alokpatel11290
Copy link
Contributor

Description

Implementation

  • We have created an API to get the message using the message id
  • Added Unit Test for the same API
  • Added sharedMessage, disclaimer & sid fields to the InboundMessage following V4Message structure on the agent

thibauult
thibauult approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@thibauult thibauult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thibauult thibauult merged commit d4e1609 into finos:1.1-rc May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibauult thibauult thibauult approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alokpatel11290 @thibauult