SDK-75 Fixed random SSL issues for RSA authentication #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibauult
changed the title
thibauult
added a commit
that referenced
this pull request
Jun 1, 2020
* SDK-75 Fixed SSL issues for RSA authentication * SDK-75 Added doc for Retry configuration * SDK-75 Added unit tests, simplified SymConfig class with Lombok usage * SDK-75 Added more unit tests, better error management in SymBotRSAAuth when JWT needs to be refreshed (cherry picked from commit 86e5410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer faced some random troubles with custom truststore configuration. I discovered that this problem was caused by the multi-threaded calls when authenticating a service account with RSA.
This PR completely refactor the way that RSA authentication is performed by the SDK. I also introduced
resilience4jas an experimental library for retries. It is also possible to configure the exponential backoff throughconfig.json:{ "retry": { "maxAttempts": 10, "initialIntervalMillis": 500, "multiplier": 1.5 } }