APP-2884 #175
Merged
APP-2884 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define new structure for Configuration in 2.0 in BdkConfig.java. Both of yaml and json formats are supported in 2.0, so Yaml parser is added for parsing Yaml config LegacyConfig model for supporting the legacy version of configuration. Configuration is loaded by BdkConfigLoader in three ways: - From path of config file: BdkConfigLoader#loadFromFile - From inputstream: BdkConfigLoader#loadFromInputStream - From classpath: BdkConfigLoader#loadFromClasspath Set minimum code coverage score: 0.9
Refactor config loading function, handle both Config v1 and v2 in one function. Configuration v1 will be automatically converted to config v2 instance. Add a static function BdkConfig#fromLegacyConfig to convert config from v1 to v2. Class BdkConfigParser to parse config input stream to detect if config is in JSON or YAML format.
InputStream cannot be read again after the first read -> read content from InputStream first and detect format from the extracted content Using JsonMapper#convertValue instead of JsonMapper#readValue to avoid JsonProcessingException Move LegacyConfigMapper to legacy package Using JsonNode#isMissingNode() instead of equals null Add very first unittest to make sure the Loader is working
| @@ -20,14 +24,18 @@ | |||
| public static JsonNode parse(InputStream inputStream) throws BdkConfigException { | |||
| JSON_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | |||
| YAML_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | |||
| String content = new BufferedReader( | |||
There was a problem hiding this comment.
since we have commons io as a dependency we could use IOUtils.toString(inputstream)
|
|
||
| @Test | ||
| public void loadFromJsonFileTest() throws JsonProcessingException, BdkConfigException { | ||
| String configPath = System.getProperty("user.dir") + "/src/test/resources/config.json"; |
There was a problem hiding this comment.
Does it work in IDEA? not sure the default current folder is the module's folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputStream cannot be read again after the first read
-> read content from InputStream first and detect format
from the extracted content
Using JsonMapper#convertValue instead of JsonMapper#readValue
to avoid JsonProcessingException
Move LegacyConfigMapper to legacy package
Using JsonNode#isMissingNode() instead of equals null
Add very first unittest to make sure the Loader is working