Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CES-1719: Added the images field to Attachment #185

Merged
merged 1 commit into from
Aug 27, 2020
Merged

CES-1719: Added the images field to Attachment #185

merged 1 commit into from
Aug 27, 2020

Conversation

anandpadiya
Copy link
Contributor

Description

Implementation

  • We want to make use of the thumbnail of the image attachment.
  • We can see that the agent is already sending that inside the attachment object in the images field.
  • This field was missing in the Attachment class. So, we have added it.

@anandpadiya anandpadiya mentioned this pull request Aug 26, 2020
Merged
thibauult
thibauult approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@thibauult thibauult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thibauult thibauult merged commit 8f8c61e into finos:1.1-rc Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibauult thibauult thibauult approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandpadiya @thibauult @anandcpadiya