Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-3072: Load parent URL configuration with Spring Boot #243

Merged

Conversation

symphony-youri
Copy link
Contributor

Ticket

APP-3072

Description

When Spring Boot was used the overriding mechanism we introduced where
you can define the host, scheme, port and context at the top level and
also override it for each sub component (agent, pod, ...) was not used.

The logic has been builtin directly in the POJOs so it is always applied
either when we use Jackson to deserialize or the Spring Boot
configuration framework.

Dependencies

N/A

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • [N/A] Javadoc added or updated
  • [N/A] Updated the documentation in docs folder

When Spring Boot was used the overriding mechanism we introduced where
you can define the host, scheme, port and context at the top level and
also override it for each sub component (agent, pod, ...) was not used.

The logic has been builtin directly in the POJOs so it is always applied
either when we use Jackson to deserialize or the Spring Boot
configuration framework.
@symphony-youri symphony-youri requested a review from a team September 25, 2020 14:18
Copy link
Contributor

@symphony-elias symphony-elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@symphony-hong symphony-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thibauult thibauult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@symphony-youri symphony-youri merged commit 3b0efc9 into finos:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants