-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APP-3083 Core SpringBoot Starter documentation #251
APP-3083 Core SpringBoot Starter documentation #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could like to the example module in the BDK as it is a complete project with all the required files
How can we use obo with Spring, is there a way to retrieve the SymphonyBdk object?
docs/spring-boot/core-starter.md
Outdated
|
||
## Installation | ||
|
||
The following listing shows the `pom.xml` file that is created when you choose Maven: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created by who? the generator?
docs/spring-boot/core-starter.md
Outdated
|
||
@EventListener | ||
public void onMessageSent(RealTimeEvent<V4MessageSent> event) { | ||
this.messageService.send(event.getSource().getMessage().getStream(),"<messageML>Hello!</messageML>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a space is missing between the parameters (formatting psycho....)
out of the scope here but:
event.getSource().getMessage().getStream() is a bit ugly
this.messageService.reply(event, "Hello!"); would be nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.messageService.reply(event, "Hello!"); would be nice :)
The problem here is that RealTimeEvent<T>
is only part of the Spring module. But we could however however assume that RealTimeEvent
has a streamId
property, that is common for a Real Time Events.
Let me have a look!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that would be impossible, as V4ConnectionRequested
and V4ConnectionAccepted
events are not related to a stream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, the ConnectionRequest
and ConnectionAccept
event, they don't have streamId
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe this.messageService.reply(event.getSource(), "Hello!");
then?
docs/spring-boot/core-starter.md
Outdated
@@ -0,0 +1,257 @@ | |||
# BDK Core SpringBoot Starter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring Boot (with the space)
docs/spring-boot/core-starter.md
Outdated
private ActivityRegistry activityRegistry; | ||
} | ||
``` | ||
> Please note that field injection is not recommended, you should consider using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then perhaps we should not show an example using field injection :) (but it is shorter...)
So maybe we could just list the available services?
|
||
Here's the list of Real Time Events you can subscribe: | ||
```java | ||
@Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a BDK user is there a way to discover all the events I can use (they don't all inherit the same class)?
…n' into APP-3083_SpringBoot-documentation
Ticket
APP-3083
Description
BDK Core Spring Boot Starter reference documentation.
Checklist