APP-3110 Handlebars template implementation #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return getTemplateFromFile(templatePath); | ||
| final String directory = FilenameUtils.getFullPathNoEndSeparator(templatePath); | ||
| final String file = FilenameUtils.getName(templatePath); | ||
| final Configuration configuration = createConfiguration(); // for thread-safety, we need to re-create configuration |
There was a problem hiding this comment.
Thanks for putting this useful, because FreeMarker does not recommend to create a new configuration each time we load a template.
There was a problem hiding this comment.
The risk here was to update static configuration at method call level, it could be problematic in multi-threaded environment such as Spring Boot applications.
symphony-youri
approved these changes
Oct 5, 2020
| @@ -53,11 +53,11 @@ If you want to use [Maven](https://maven.apache.org/) as build system, you have | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.symphony.platformsolutions</groupId> | |||
| <artifactId>symphony-bdk-core-invoker-jersey2</artifactId> | |||
| <artifactId>symphony-bdk-http-jersey2</artifactId> <!-- or symphony-bdk-http-webclient --> | |||
There was a problem hiding this comment.
maybe we should update that according to the discussion we had about runtime scope?
docs/message.md
Outdated
| but we may add support for other template engines. | ||
| For instance, if you have the following template file: | ||
| ### How to send a message from a template | ||
| > In the code examples below, we will assume that FreeMarker as been selected as template engine implementation |
There was a problem hiding this comment.
should we detail how the selection is made (i.e whatever is in the classpath is used)?
One could think that there is an API to call to select the engine
There was a problem hiding this comment.
I documented how to select the implementation. And I also created APP-3113 to fix the current behaviour which was to randomly decide which implementation is selected by default
…mphony-bdk-core transitive dependencies
thibauult
added a commit
to thibauult/symphony-bdk-java
that referenced
this pull request
Oct 5, 2020
* APP-3110 Handlebars template engine implementation * APP-3110 doc * APP-3110 Post merge, updated getting-started guide * APP-3110 http and template implementations as runtime dependencies * APP-3110 reverted ./docs/index.md * APP-3110 Updates implementation selection * APP-3110 :symphony-bdk-http-api and :symphony-bdk-template-api as :symphony-bdk-core transitive dependencies (cherry picked from commit edb1844)
thibauult
added a commit
to thibauult/symphony-bdk-java
that referenced
this pull request
Oct 5, 2020
* APP-3110 Handlebars template engine implementation * APP-3110 doc * APP-3110 Post merge, updated getting-started guide * APP-3110 http and template implementations as runtime dependencies * APP-3110 reverted ./docs/index.md * APP-3110 Updates implementation selection * APP-3110 :symphony-bdk-http-api and :symphony-bdk-template-api as :symphony-bdk-core transitive dependencies (cherry picked from commit edb1844)
thibauult
added a commit
that referenced
this pull request
Oct 5, 2020
* APP-3082 Architecture Overview (#258) * APP-3082 SVG Rendering in Markdown test * APP-3082 Updated diagram * APP-3082 Removed unused Jersey dependency * APP-3082 WIP * APP-3110 arch doc * APP-3110 removed unused javax.ws.rs.core.GenericType import from ApiException class * APP-3082 fixes * APP-3082 Link to Architecture Presentation from ./docs/index.md (cherry picked from commit 0fa637b) * APP-3110 Handlebars template implementation (#260) * APP-3110 Handlebars template engine implementation * APP-3110 doc * APP-3110 Post merge, updated getting-started guide * APP-3110 http and template implementations as runtime dependencies * APP-3110 reverted ./docs/index.md * APP-3110 Updates implementation selection * APP-3110 :symphony-bdk-http-api and :symphony-bdk-template-api as :symphony-bdk-core transitive dependencies (cherry picked from commit edb1844) * APP-3078: Add java-library plugin to http and template submodules (#261) * Add internal dependencies version to bom module * Update missing dependencies * Adding plugin to http and template submodule (cherry picked from commit f5c7df0) * Bump release version to 1.3.1.BETA * Updated current version in getting-started.md * APP-3110 Handlebars template implementation (#260) * APP-3110 Handlebars template engine implementation * APP-3110 doc * APP-3110 Post merge, updated getting-started guide * APP-3110 http and template implementations as runtime dependencies * APP-3110 reverted ./docs/index.md * APP-3110 Updates implementation selection * APP-3110 :symphony-bdk-http-api and :symphony-bdk-template-api as :symphony-bdk-core transitive dependencies (cherry picked from commit edb1844) * Bumped legacy version Co-authored-by: symphony-hong <65538951+symphony-hong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
APP-3110
Description
Handlerbars implementation for the Template API for adoption purpose, as it is the default implementation provided by legacy sms-sdk-renderer-java library.
I also decided to simplify this API by removing the built-in templates feature that is not very useful at the moment, as we are not really providing any real built-in template. We might reconsider this feature in the future, depending on developers needs for that, but for now I really think that we don't necessary need to publish it in order to avoid any question like "why it exists but there is only 1
simpleMMLtemplate?".Checklist