Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-3103: Add @JsonIgnore to the OutboundMessage#setContentAttachment(ContentAttachment) #282

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

symphony-hong
Copy link
Contributor

@symphony-hong symphony-hong commented Oct 12, 2020

Ticket

APP-3103

Description

There are two setters setContentAttachment in OutboundMessage which can lead to
ambigous reference error while deserializing with Jackson. Associated
OutboundMessage#setContentAttachment(ContentAttachment) with @JsonIgnore to
prevent Jackson use this setter to deserialize

Dependencies

List the other pull requests that should be merged before/along this one.

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
…tachment)

There are two method setContentAttachment in OutboundMessage which can lead to
ambigous reference error while deserializing with Jackson. Associated
OutboundMessage#setContentAttachment(ContentAttachment) with @JsonIgnore to
prevent Jackson use this setter to deserialize
Copy link
Contributor

@symphony-elias symphony-elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@symphony-hong symphony-hong merged commit 4512e02 into finos:master Oct 12, 2020
@symphony-hong symphony-hong deleted the APP-3103 branch October 12, 2020 13:26
symphony-hong added a commit to symphony-hong/symphony-bdk-java that referenced this pull request Oct 26, 2020

Verified

This commit was signed with the committer’s verified signature.
…tachment) (finos#282)

There are two method setContentAttachment in OutboundMessage which can lead to
ambigous reference error while deserializing with Jackson. Associated
OutboundMessage#setContentAttachment(ContentAttachment) with @JsonIgnore to
prevent Jackson use this setter to deserialize

(cherry picked from commit 4512e02)
symphony-hong added a commit that referenced this pull request Oct 26, 2020

Verified

This commit was signed with the committer’s verified signature.
* Add @JsonIgnore to the OutboundMessage#setContentAttachment(ContentAttachment) (#282)

There are two method setContentAttachment in OutboundMessage which can lead to
ambigous reference error while deserializing with Jackson. Associated
OutboundMessage#setContentAttachment(ContentAttachment) with @JsonIgnore to
prevent Jackson use this setter to deserialize

(cherry picked from commit 4512e02)

* Update new spring boot auto property expansion strategy for gradle project (#300)

The legacy strategy for expanding property (`@symphony.apiclient.version@`) only works with
Maven project. Since we decided to use gradle instead, this expansion haven't worked anymore.
That's why we have to update the properties file with the gradle auto property expansion.
More details: https://docs.spring.io/spring-boot/docs/1.4.x/reference/html/howto-properties-and-configuration.html#howto-automatic-expansion-gradle

(cherry picked from commit d0d8dd2)

* Bump version of legacy sdk to 1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants