Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-3120 Handlebars does not automatically append .hbs extension to template name #283

Merged

Conversation

thibauult
Copy link
Member

Ticket

APP-3120

Description

By default, Handlebars automatically appends .hbs extension to template names. This behaviour is not consistent with with existing Freemarker implementation.

Dependencies

N/A

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

@thibauult thibauult requested a review from a team October 12, 2020 14:35
Copy link
Contributor

@symphony-elias symphony-elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thibauult thibauult merged commit da08399 into finos:master Oct 12, 2020
@thibauult thibauult deleted the APP-3120_Handlebars-does-not-append-hbs-ext branch October 12, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants