APP-3104: Fluent OBO API for services #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-elias
requested review from
thibauult,
symphony-youri and
symphony-hong
thibauult
reviewed
Oct 12, 2020
symphony-bdk-core/src/main/java/com/symphony/bdk/core/OboServiceFactory.java
Outdated
Show resolved
Hide resolved
symphony-bdk-core/src/main/java/com/symphony/bdk/core/service/user/OboUserService.java
Outdated
Show resolved
Hide resolved
symphony-bdk-core/src/main/java/com/symphony/bdk/core/OboServicesFacade.java
Outdated
Show resolved
Hide resolved
symphony-bdk-core/src/main/java/com/symphony/bdk/core/OboServicesFacade.java
Outdated
Show resolved
Hide resolved
| @@ -55,18 +41,14 @@ | |||
| */ | |||
| @Slf4j | |||
| @API(status = API.Status.STABLE) | |||
| public class MessageService { | |||
| public class MessageService extends OboMessageService { | |||
There was a problem hiding this comment.
I'm a bit afraid of inheritance bringing problems later as it introduces a lot of coupling, do we have use cases where you would need the message service to be used either as OBO or not OBO (i.e the need to have a common parent class/interface)
Have we looked at existing bots to see how they use OBO and if they mix OBO / non OBO usages?
There was a problem hiding this comment.
Composition instead of inheritance? We could consider using https://projectlombok.org/features/Delegate.html
symphony-bdk-core/src/main/java/com/symphony/bdk/core/service/OboService.java
Outdated
Show resolved
Hide resolved
|
👍 for the interface approach |
|
Let's push it further with the Spring Boot integration (or in a separate PR if you prefer) |
thibauult
reviewed
Oct 14, 2020
symphony-bdk-core/src/main/java/com/symphony/bdk/core/service/stream/StreamService.java
Show resolved
Hide resolved
symphony-bdk-core/src/test/java/com/symphony/bdk/core/OboServicesTest.java
Outdated
Show resolved
Hide resolved
symphony-bdk-core/src/test/java/com/symphony/bdk/core/OboServicesTest.java
Outdated
Show resolved
Hide resolved
...bdk-core-spring-boot-starter/src/main/java/com/symphony/bdk/spring/config/BdkCoreConfig.java
Show resolved
Hide resolved
thibauult
reviewed
Oct 14, 2020
symphony-bdk-core/src/test/java/com/symphony/bdk/core/OboServicesTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
APP-3104
Description
Implemented Fluent API for OBO endpoints
Checklist