Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-3136: WebClient implementation of multiple attachments #288

Merged
merged 3 commits into from
Oct 14, 2020
Merged

APP-3136: WebClient implementation of multiple attachments #288

merged 3 commits into from
Oct 14, 2020

Conversation

symphony-elias
Copy link
Contributor

@symphony-elias symphony-elias commented Oct 14, 2020

Ticket

APP-3136

Description

WebClient implementation can now send multiple attachment.
Added logic in MessageBuilder regarding previews and attachment in accordance with checks done in the agent.

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

Copy link
Member

@thibauult thibauult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@symphony-elias symphony-elias merged commit 881d2d0 into finos:master Oct 14, 2020
@symphony-elias symphony-elias deleted the APP-3136 branch October 14, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants