Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-3209: Change all dependecies from implementation scope to api #314

Merged
merged 2 commits into from
Oct 30, 2020
Merged

APP-3209: Change all dependecies from implementation scope to api #314

merged 2 commits into from
Oct 30, 2020

Conversation

symphony-hong
Copy link
Contributor

Ticket

APP-3209

Description

Changing scope of all dependencies in legacy modules from implementation to api to make them referenceable in bot project.

Dependencies

List the other pull requests that should be merged before/along this one.

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any

@symphony-hong symphony-hong requested review from thibauult, a team and symphony-youri October 30, 2020 09:29
@symphony-hong symphony-hong merged commit 168bdd5 into finos:master Oct 30, 2020
@symphony-hong symphony-hong deleted the APP-3209 branch October 30, 2020 12:55
symphony-hong added a commit to symphony-hong/symphony-bdk-java that referenced this pull request Oct 30, 2020
@symphony-hong
APP-3209: Change all dependecies from implementation scope to api (fi…
9278b22 
…nos#314)

(cherry picked from commit 168bdd5)
@symphony-hong symphony-hong mentioned this pull request Oct 30, 2020
Merged
symphony-hong added a commit that referenced this pull request Oct 30, 2020
@symphony-hong
Backporting changes on Legacy SDK from master to 1.3 rc (#316)
ae0c95a 
* APP-3209: Change all dependecies from implementation scope to api (#314)

(cherry picked from commit 168bdd5)

* Update OboUserService according to changes on swagger spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphony-youri symphony-youri symphony-youri approved these changes

@thibauult thibauult Awaiting requested review from thibauult

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symphony-hong @symphony-youri