Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#462 Fixed HttpClient NPE when adding query param #463

Merged

Conversation

thibauult
Copy link
Member

Ticket

Closes #462

Description

Map and List from class HttpClient#RequestConfig were not correctly initialized with default values. This was leading to the NPE detected in #462.

Checklist

  • Referenced a ticket in the PR title and in the corresponding section
  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

@thibauult thibauult requested a review from a team as a code owner March 2, 2021 10:40
@thibauult thibauult added this to the 2.1.1 milestone Mar 2, 2021
@thibauult thibauult linked an issue Mar 2, 2021 that may be closed by this pull request
@thibauult thibauult merged commit 5b16c44 into finos:2.1-rc Mar 2, 2021
@thibauult thibauult deleted the #462_HttpClient-NPE-when-adding-query-param branch March 2, 2021 10:55
@thibauult thibauult modified the milestones: 2.1.x, 2.1.1 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient NPE bug when add queryparam
2 participants