Fix ConcurrentModificationException in Datafeed loop #475 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ConcurrentModificationException can happen in the Datafeed (DF) loop upon startup. The access to the listeners collection in the DF loop is not protected and accessed by multiple threads. Because of the for loop we need to synchronize on the list itself.
|
I'm not super happy with the sleep in the test but I could not a better way :/ |
thibauult
reviewed
Mar 17, 2021
| }); | ||
|
|
||
| // we want to make sure the addANewListener is started and blocking before unblocking the first listener | ||
| Thread.sleep(100); |
There was a problem hiding this comment.
How long does it take to execute in the end?
There was a problem hiding this comment.
100ms + a few more ms for it to do the rest
thibauult
approved these changes
Mar 17, 2021
symphony-youri
added a commit
to symphony-youri/symphony-api-client-java
that referenced
this pull request
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ConcurrentModificationException can happen in the Datafeed (DF) loop upon startup.
The access to the listeners collection in the DF loop is not protected
and accessed by multiple threads.
Because of the for loop we need to synchronize on the list itself.
Fixes #475