#483 Jwt Cookie set with SameSite=Strict #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-hong
added
the
Mend: dependency security vulnerability
The request to /bdk/v1/app/auth appears to be vulnerable to cross-site request forgery (CSRF) attacks against authenticated users. The request can be issued cross-domain. The BDK relies solely on HTTP cookies to identify the user that issued the request. The request performs some privileged action within the application, which returns a token. The attacker can determine all the parameters required to construct a request that performs the action. If the request contains any values that the attacker cannot determine or predict, then it is not vulnerable. Setting the SameSite=Strict will prevent sending the cookie when the request is done from another domain.
|
Isn't it going to break https://perzoinc.atlassian.net/browse/APP-3271 ? |
|
IMHO, what we did in the APP-3271 is not the right way to perform the cross-site call in security sense. |
thibauult
changed the title
|
Does someone remember why we set the userJwt cookie in the first place by the way? |
thibauult
approved these changes
Apr 2, 2021
For "backward compatibility" I'd say. User session could also be stored in local storage though, however cookies are stored automatically and therefore doesn't require any additional code on client side. |
|
@symphony-hong, sorry I forgot to tell you, but could you backport this change to |
symphony-hong
added a commit
to symphony-hong/symphony-bdk-java
that referenced
this pull request
Apr 5, 2021
* EIS-2766: Jwt Cookie set with SameSite=Strict The request to /bdk/v1/app/auth appears to be vulnerable to cross-site request forgery (CSRF) attacks against authenticated users. The request can be issued cross-domain. The BDK relies solely on HTTP cookies to identify the user that issued the request. The request performs some privileged action within the application, which returns a token. The attacker can determine all the parameters required to construct a request that performs the action. If the request contains any values that the attacker cannot determine or predict, then it is not vulnerable. Setting the SameSite=Strict will prevent sending the cookie when the request is done from another domain. * Make sameSite attribute configurable with default value = Strict
symphony-hong
added a commit
that referenced
this pull request
Apr 6, 2021
* EIS-2766: Jwt Cookie set with SameSite=Strict The request to /bdk/v1/app/auth appears to be vulnerable to cross-site request forgery (CSRF) attacks against authenticated users. The request can be issued cross-domain. The BDK relies solely on HTTP cookies to identify the user that issued the request. The request performs some privileged action within the application, which returns a token. The attacker can determine all the parameters required to construct a request that performs the action. If the request contains any values that the attacker cannot determine or predict, then it is not vulnerable. Setting the SameSite=Strict will prevent sending the cookie when the request is done from another domain. * Make sameSite attribute configurable with default value = Strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #483
Description
The request to /bdk/v1/app/auth appears to be vulnerable
to cross-site request forgery (CSRF) attacks against authenticated users.
The request can be issued cross-domain.
The BDK relies solely on HTTP cookies to identify the user that issued the request.
The request performs some privileged action within the application, which returns a token.
The attacker can determine all the parameters required to construct a request that
performs the action. If the request contains any values that the attacker cannot
determine or predict, then it is not vulnerable.
Setting the SameSite=Strict will prevent sending the cookie when the request is done from another domain.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist