Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#504 DatafeedLoop now retries on 500 server errors #509

Merged
merged 5 commits into from
Apr 30, 2021
Merged

#504 DatafeedLoop now retries on 500 server errors #509

merged 5 commits into from
Apr 30, 2021

Conversation

thibauult
Copy link
Member

@thibauult thibauult commented Apr 29, 2021 •
edited
Loading

Ticket

Fixes #504

Description

We recently noticed that the DatafeedLoop was crashing with 500 errors returned from Agent. This is something we initially stated that we did not wanted to retry on this specific status. Now we do :) It has actually been raised by some customers.

Will have to be backported to 2.1-rc branch.

@thibauult thibauult requested a review from a team as a code owner April 29, 2021 18:00
@thibauult thibauult added this to the 2.1.6 milestone Apr 29, 2021
symphony-youri
symphony-youri reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@symphony-youri symphony-youri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add test to check that 500 is indeed a server error?
(also in the commit it would be interesting to describe why we made the change, when I look at Git's history I don't want to navigate to a PR :))

@thibauult thibauult merged commit 67eab48 into finos:main Apr 30, 2021
@thibauult thibauult deleted the #504_Retry-on-500 branch April 30, 2021 10:13
thibauult added a commit that referenced this pull request Apr 30, 2021
@thibauult
#504 Status 500 is now really considered as a server error (#509)
81025a4 
We recently noticed that the DatafeedLoop was crashing with `500` errors returned from Agent. This is something we initially stated that we did not wanted to retry on this specific status. Now we do, as it has actually been raised by some customers.
@thibauult thibauult mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphony-elias symphony-elias symphony-elias approved these changes

@symphony-youri symphony-youri symphony-youri approved these changes

@symphonydarlys symphonydarlys symphonydarlys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.6
Development

Successfully merging this pull request may close these issues.

HTTP 500 errors should be retried
4 participants
@thibauult @symphonydarlys @symphony-youri @symphony-elias