Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 11912 #650

Closed
wants to merge 21 commits into from
Closed

Plat 11912 #650

wants to merge 21 commits into from

Conversation

symphony-elias
Copy link
Contributor

@symphony-elias symphony-elias commented Apr 4, 2022

Description

Preparing for 2.6.1 release

Contains

Features

#625 : Polish Groups API
#632 : Target specific commit for symphony-api-specs
#633 : Supported a list of files in multipart form data
#637 : Support user apps patch
#643 : Deprecating DFv1

Dependency upgrades

#624 : Upgraded to Gradle to 7.3.3
#629 : Upgrade Hazelcast version in examples
#630 : Upgrade dependencies
#635 : Upgrade Hazelcast
#636 : Upgrade dependencies (SB 2.6.4)
#642 : Upgrade Jackson to 2.13.2
#649 : Upgraded Spring Boot to 2.6.6
#646 : Upgrading dependencies

Documentation

#626 : Update PR template
#627 : Add proxy configuration example
#639 : Example to import messages with attachments
#641 : Generate javadoc for group extension
#644 : Fixing broken documentation links

thibauult and others added 21 commits April 4, 2022 16:21
Pull request template should not mention Jira ticket since open source contributors do not necessarily have access to our Jira board. Issues should be used instead.
* PLAT-11729: Simplified groups api endpoints and removed group type endpoints as it is not documented

* Implemented cursor based pagination
 
* Implemented pagination for listGroups endpoint

* Moved UserService endpoints listFollowers, listFollowing, listAuditTrail to cursor based pagination

* Added unit test coverage check on symphony-group-extension module
Mainly Spring Boot 2.6.1 -> 2.6.3

Also introduce the versions plugin so we can check available upgrades
with: gradle dependencyUpdates
If the test is a bit slow, then timestamp will differ, use the same one.
* Target specific commit for symphony-api-specs

Goal of this PR is to start targeting a specific commit of the Symphony-api-spec repository and not always target the master branch, this way we'll have more control over compatibility and what features are included in each BDK version.
Also since from 20.14 we are starting deprecation of apps authentication endpoint using certificate, we are going to generate the code from the authenticator-api-public-deprecated.yaml file so that we still support those apis.
The HttpClient provided by the BDK was not supporting File objects as a form param value
whether it was one single File object or several File objects for a given form param key
Also upgrade plugins and try to avoid Snyk reports on build only
dependencies.
Closes #637
Added the support of user apps patch in ApplicationService
* Provide example to import messages with attachments

Starting from Agent 20.14 we are now able to use the already existing Import Message API (https://developers.symphony.com/restapi/reference/import-message-v4) to import attachments as well along with the message.
A list of attachments can be added to the V4ImportedMessage object providing for each attachment a filename (with the file extension) and the file content in base64 format
Also fix build warnings about etag for API specs.
Also update the url to symphony-api-spec and avoid using master to make
sure builds are reproductible.
* Starting Datafeed v1 deprecation process
The datafeed 1 service will be fully replaced by the datafeed 2 service in the future. Please consider migrating over to datafeed 2. For more information on the timeline as well as on the benefits of datafeed 2, please reach out to your Technical Account Manager or to our developer documentation https://docs.developers.symphony.com/building-bots-on-symphony/datafeed
This PR includes:
- if datafeed version is not defined in the config, the BDK will use DFv2 by default
- added deprecation notice when DFv1 is used (both in the code and in the documentation)
- APIs generation is been updated following swagger deprecation of the APIs finos/symphony-api-spec#143
Some of the documentation links were outdated, goal of this implementation is to replaced them with working links.
* Upgrading dependencies
* Updating spring boot version in the examples
* Upgrading latest jackson-bom
@symphony-elias symphony-elias requested a review from a team as a code owner April 4, 2022 14:38
@symphony-youri
Copy link
Contributor

Maybe some of the changes here would rather be a 2.7.0 ? (like #643)

@symphony-elias
Copy link
Contributor Author

Closed because it is replaced by a new 2.7-rc branch and #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants