Update health check status code strategy #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separte DataFeedLoop health check from the other components, set the global status to out of service only if DataFeedLoop is down. In this case, when calling healtch check endpoint, the resposne http code is 500, otherwise if any other components is down, set the global status to "WARNING", the http code of the response stays as 200. This will avoid unncessary BDK Bot restarting when other components are not healthy.
yinan-symphony
changed the title
Yannick-Malins
approved these changes
Feb 13, 2024
vladokrsymphony
pushed a commit
that referenced
this pull request
Mar 25, 2024
Separte DataFeedLoop health check from the other components, set the global status to out of service only if DataFeedLoop is down. In this case, when calling healtch check endpoint, the resposne http code is 500, otherwise if any other components is down, set the global status to "WARNING", the http code of the response stays as 200. This will avoid unncessary BDK Bot restarting when other components are not healthy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate DataFeedLoop health check from the other components, set the global status to out of service only if DataFeedLoop is down. In this case, when calling health check endpoint, the response http code is 503, otherwise if any other components is down, set the global status to "WARNING", the http code of the response stays as 200.
This will avoid unnecessary BDK Bot restarting when other components are not healthy.
Remove the custom status code mapper, and use the default mapping behaviour of Spring Boot.
Description
Closes #[ISSUE NUMBER]
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist