Add silent message update support #287
Conversation
| @@ -4,7 +4,7 @@ code_gen_dir=`pwd` | |||
| project_root=$code_gen_dir/.. | |||
| echo $code_gen_dir | |||
|
|
|||
| commit_hash=136b530512eea112de73591906051871d034750a | |||
There was a problem hiding this comment.
When we update this commit hash, we might want to run the sh script to update the generated code. See here https://github.com/finos/symphony-bdk-python/blob/main/docsrc/markdown/tech/generated_api.md
There was a problem hiding this comment.
And include the new generated files in the PR of course.
There was a problem hiding this comment.
sure, i am doing it now
There was a problem hiding this comment.
@symphony-soufiane done.
| @@ -466,7 +466,7 @@ async def search_messages_one_page(skip, limit): | |||
|
|
|||
| @retry | |||
| async def update_message(self, stream_id: str, message_id: str, message: Union[str, Message], data=None, | |||
| version: str = "") -> V4Message: | |||
| silent=True, version: str = "") -> V4Message: | |||
There was a problem hiding this comment.
I'm wondering if adding this parameter doesn't break the backward compatibility. I would rather add a new method that takes this new argument, and I call it in this one with the default silent value (True).
There was a problem hiding this comment.
i checked this point actually. this silent=True syntax in python is working as an optional arg with the default value. so user can choose to specify it or simply ignore it, in this case the default value is applied.
you can see that the unit test does not change the signature, but it is still working.
yinan-symphony
force-pushed
the
feature/silent-message-update
branch
from
e74e31c to
d07b36e
Compare
- Update Symphony APIs spec version - Add silent flag support according to the new spec. When silent is true, the new updated message is marked as read, otherwise is unread. True is the default value.
yinan-symphony
force-pushed
the
feature/silent-message-update
branch
from
d07b36e to
8135810
Compare
Update Symphony APIs spec version
Add silent flag support according to the new spec.
When silent is true, the new updated message is marked as read, otherwise is unread.
True is the default value.
Description
Closes #[ISSUE NUMBER]
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist