Fix DF2 ID format regex pattern bug #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing feed id does not have the suffix after '_f', which does not matche with the regex pattern. With this commit, the regex pattern will match the existing DF ID as well as the new DF ID value (haveing the suffix after '_f').
symphony-soufiane
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing feed id does not have the suffix after '_f',
which does not matche with the regex pattern.
With this commit, the regex pattern will match the existing
DF ID as well as the new DF ID value (haveing the suffix
after '_f').
Description
Closes #[ISSUE NUMBER]
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist