-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ Generic runtime data protocols #462
Merged
martin-traverse
merged 19 commits into
finos:main
from
martin-traverse:feature/runtime_data_protocols
Oct 24, 2024
Merged
Feature/ Generic runtime data protocols #462
martin-traverse
merged 19 commits into
finos:main
from
martin-traverse:feature/runtime_data_protocols
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not be type checked though)
…rarchies and explicitly skipping individual parameters
…y a separate converter class
…table the primary API for accessing data in the context
…ld approach, which was needed because conformance sometimes needs to know details from the public data API type
…pping the new logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make DATA_API a generic type (e.g. pandas, polars etc.)
Encapsulate logic for each data API into a single converter class
Allow TRAC to run when some data modules are missing
Pandas is still a hard dependency for now, but it doesn't have to be, this could be changed in the next major release