Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register RPC response types #1010

Closed
naleeha opened this issue Nov 24, 2023 · 0 comments
Closed

Register RPC response types #1010

naleeha opened this issue Nov 24, 2023 · 0 comments
Assignees
@naleeha
Labels
bug Something isn't working

Comments

@naleeha
Copy link
Contributor

naleeha commented Nov 24, 2023 •
edited
Loading

Observation:
When calling RPC fails, the server throws exception rather than returning helpful error message
e.g. when ui calls rpcName that doesn't exist

Cause:
This seem to be because it does not know how to json serialise ViewPortRpcFailure

Action:
need to register the json sub type for ViewPortRpcFailure and ViewPortRpcSuccess
@naleeha naleeha self-assigned this Nov 24, 2023
@naleeha naleeha converted this from a draft issue Nov 24, 2023
@naleeha naleeha moved this from 🆕 New to 🏗 In progress in Vuu board Nov 24, 2023
@naleeha naleeha added the bug Something isn't working label Nov 24, 2023
@naleeha naleeha moved this from 🏗 In progress to 🔖 Ready in Vuu board Nov 24, 2023
@naleeha naleeha moved this from 🔖 Ready to 👀 In review in Vuu board Nov 28, 2023
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 5, 2023
@naleeha
finos#1010 registring ViewPortRpcSuccess
fd42183
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 5, 2023
@naleeha
finos#1010 re-naming to VP_EDIT_FAILURE and VP_RCP_FAILURE for consis…
99cefd4 
…tency
chrisjstevo pushed a commit that referenced this issue Dec 5, 2023
@naleeha @chrisjstevo
#1010 registring ViewPortRpcSuccess
f0271eb
chrisjstevo pushed a commit that referenced this issue Dec 5, 2023
@naleeha @chrisjstevo
#1010 re-naming to VP_EDIT_FAILURE and VP_RCP_FAILURE for consistency
f1eece8
@naleeha naleeha moved this from 👀 In review to ✅ Done in Vuu board Dec 5, 2023
@naleeha naleeha moved this from ✅ Done to 👀 In review in Vuu board Dec 5, 2023
@naleeha naleeha changed the title Register RCP response types Register RPC response types Dec 6, 2023
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 7, 2023
@naleeha
finos#1010 registring ViewPortRpcSuccess
a6d3173
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 7, 2023
@naleeha
finos#1010 re-naming to VP_EDIT_FAILURE and VP_RCP_FAILURE for consis…
351a5b2 
…tency
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 7, 2023
@naleeha
finos#1010 correcting name of RPC response message
c57daf3
chrisjstevo pushed a commit that referenced this issue Dec 29, 2023
@naleeha @chrisjstevo
#1010 correcting name of RPC response message
5019ce6
chrisjstevo pushed a commit that referenced this issue Dec 29, 2023
@naleeha @chrisjstevo
#1010 correcting name of RPC response message
fe3e5c2
@naleeha naleeha moved this from 👀 To be tested in QA to ✅ Done in Vuu board Jan 11, 2024
@naleeha naleeha closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naleeha naleeha

Labels
bug Something isn't working
Projects
Vuu board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naleeha