Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Date and time formatting optionsd to Column Settings Panel #1073

Closed
Tracked by #1071
heswell opened this issue Dec 11, 2023 · 1 comment
Closed
Tracked by #1071

Add Date and time formatting optionsd to Column Settings Panel #1073

heswell opened this issue Dec 11, 2023 · 1 comment
Assignees
Labels
date-handling UI user Interface

Comments

@heswell
Copy link
Contributor

heswell commented Dec 11, 2023

The Column Settings panel offers users a UI for applying changes to column configuration settings. Some of the settings are general (width, pin ,title etc) , others are specific to columns of particular types.
Right now, only columns of type double offer formatting settings - number of decimals align on decimals and zero pad.
Thes eare implemented in NumericFormattingSettings within the vuu-table-extras package.

Date and Time fields should offer the user the possibility to choose the formatting pattern.

@heswell
Copy link
Contributor Author

heswell commented Dec 13, 2023

The NumericFormattingSettings panel offers default formatting options for double columns, we should create a DateTimeFormattingSettings panel. Probably only needs a single dropdown to allow user to select formatting pattern.

In future we may get more granular datatype from server, so we may be able to distinguish dates from times. Right now we just get type long so we will have to offer the date time formatting options for any long field. We might want to make the Formatting panel configurable with a prop that tells it whether to offer date, time of both date and time patterns. Then later, when the server tells us the precise type of a column, we can offer just the appropriate settings.

Note that where custom renderers have been registered for columns of particular types, these may have also registered associated settings panels, which get displayed in addition to the default settings panels. See Background renderer on double columns for an example.

As we only have one implementation at the moment of formatting settings (for double columns), we may discover, when implementing same for dates, that we have to tweak the existing implementation, lets see.

@junaidzm13 junaidzm13 moved this to 🏗 In progress in Vuu board Dec 15, 2023
@junaidzm13 junaidzm13 self-assigned this Dec 15, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 15, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 15, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 27, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 28, 2023
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 28, 2023
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 28, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Dec 28, 2023
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Jan 2, 2024
- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.
heswell pushed a commit that referenced this issue Jan 2, 2024
* #1073 enable date/time pattern selection through ColumnSettings

- converges date and time column types to one unified date/time type, consistent
  with how some major programming languages handles datetime.
- date/time pattern selection is only available for columns with "date/time" type.
- changes DateTimePattern to be an object instead of strings to enable
  simultaneous selection of both date and time patterns.
- also moves DateTimeColumnDescriptor to vuu-table-types package for consistency.

* #1073 add ability to switch inferred column type for long columns

- users can now declare the type of long columns as plain number or
  date/time.
- removed isSimpleColumnType as its no longer needed.
- added a timestamps (long) column in showcase's instruments-extended
  table.

* #1073 use unformatted initial value for input-cell renderers

* #1073 only show supported cell renderers for boolean columns
@heswell heswell moved this from 🏗 In progress to 🔖 To be merged in Vuu board Jan 2, 2024
@heswell heswell moved this from 🔖 To be merged to 👀 To be tested in QA in Vuu board Jan 2, 2024
@heswell heswell closed this as completed Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 👀 To be tested in QA to ✅ Done in Vuu board Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
date-handling UI user Interface
Projects
Archived in project
Development

No branches or pull requests

2 participants