-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VUU-333: Fix Application Layouts Data Contract #1121
Open
pling-scottlogic
wants to merge
15
commits into
finos:main
Choose a base branch
from
ScottLogic:SLVUU-129-settings-in-dto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
VUU-333: Fix Application Layouts Data Contract #1121
pling-scottlogic
wants to merge
15
commits into
finos:main
from
ScottLogic:SLVUU-129-settings-in-dto
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the anti-pattern of async/await (Cypress does not work well with promises)
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the data contract for the
application-layouts
resource on the layout server. Also introduces end-to-end Cypress tests to ensure the data contract holds.Change List
ApplicationLayoutDto
withObjectNode
to allow for arbitrary JSON structureGetApplicationResponseDto
withApplicationJSON
api.utils.ts
to abstract API calls for testingApplicationJSON
interfaceTesting
Changes manually tested using the remote implementation from both showcase and sample app.