Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUU-333: Fix Application Layouts Data Contract #1121

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

pling-scottlogic
Copy link
Contributor

Description

Fixes the data contract for the application-layouts resource on the layout server. Also introduces end-to-end Cypress tests to ensure the data contract holds.

Change List

  • Backend:
    • Replace ApplicationLayoutDto with ObjectNode to allow for arbitrary JSON structure
    • Rename "definition" fields to match the frontend model
    • Synchronise default application layout JSON with local equivalent
    • Adjust server tests to reflect changes
  • Frontend:
    • Replace GetApplicationResponseDto with ApplicationJSON
    • Add Cypress tests to ensure API contract does not get violated
    • Add api.utils.ts to abstract API calls for testing
    • Rename field on ApplicationJSON interface
  • CI/CD
    • Add script to run layout server
    • Run layout server script as part of Cypress setup

Testing

Changes manually tested using the remote implementation from both showcase and sample app.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit 49f8545
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/65a0029d444a8f0009024e8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants