#1296 use parameterized SQL query builder #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
1296-use-parameterized-sql-builder-for-ignite
branch
from
4ee7c7a to
3f656ae
Compare
junaidzm13
force-pushed
the
1296-use-parameterized-sql-builder-for-ignite
branch
from
3f656ae to
978bd83
Compare
- this would prevent SQL injection while adding better support for different types i.e. for instance before we had to manually convert values to strings (with or without quotes depending on the type) before using them in SQL query. Now, ignite would do that for us.
junaidzm13
force-pushed
the
1296-use-parameterized-sql-builder-for-ignite
branch
from
978bd83 to
cf98d15
Compare
naleeha
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably covers the following issue as well: #1232