Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リファクタリング #62

Merged
merged 3 commits into from
Oct 18, 2021
Merged

リファクタリング #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f01d365
リファクタリング
finphie Oct 18, 2021
dcc909d
Update IReadOnlyUtf8ArrayDictionary.cs
finphie Oct 18, 2021
0dd6b91
Update IUtf8ArrayDictionary.cs
finphie Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Utf8Utility/IReadOnlyUtf8ArrayDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Utf8Utility;

/// <summary>
/// UTF-8文字列用の読み取り専用Dictionary
/// UTF-8配列用の読み取り専用Dictionary
/// </summary>
/// <typeparam name="TValue">Dictionary内部の値の型</typeparam>
[SuppressMessage("Naming", "CA1711:識別子は、不適切なサフィックスを含むことはできません", Justification = "Dictionary")]
Expand Down
2 changes: 1 addition & 1 deletion Source/Utf8Utility/IUtf8ArrayDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Utf8Utility;

/// <summary>
/// UTF-8文字列用のDictionary
/// UTF-8配列用のDictionary
/// </summary>
/// <typeparam name="TValue">Dictionary内部の値の型</typeparam>
[SuppressMessage("Naming", "CA1711:識別子は、不適切なサフィックスを含むことはできません", Justification = "Dictionary")]
Expand Down
8 changes: 4 additions & 4 deletions Source/Utf8Utility/Utf8Array.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ namespace Utf8Utility;
/// </summary>
public readonly struct Utf8Array
#if NET6_0_OR_GREATER
: IEquatable<Utf8Array>, ISpanFormattable
: IEquatable<Utf8Array>, ISpanFormattable
#else
: IEquatable<Utf8Array>, IFormattable
: IEquatable<Utf8Array>, IFormattable
#endif
{
readonly byte[] _value;
Expand All @@ -36,10 +36,10 @@ public readonly struct Utf8Array
public static Utf8Array Empty { get; }

/// <summary>
/// UTF-8バイト数を取得します。
/// バイト数を取得します。
/// </summary>
/// <value>
/// UTF-8バイト数
/// バイト数
/// </value>
public int Length => _value.Length;

Expand Down
4 changes: 2 additions & 2 deletions Source/Utf8Utility/Utf8ArrayDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public bool TryAdd(Utf8Array key, TValue value)

do
{
// 境界チェック削除のためにdo-while文の必要がある。
// 境界チェック削除のためにdo-while文にする必要がある。
// https://github.com/dotnet/runtime/issues/9422
if ((uint)i >= (uint)entries.Length)
{
Expand Down Expand Up @@ -199,7 +199,7 @@ public ref TValue GetValueRefOrNullRef(ReadOnlySpan<byte> key)

do
{
// 境界チェック削除のためにdo-while文の必要がある。
// 境界チェック削除のためにdo-while文にする必要がある。
// https://github.com/dotnet/runtime/issues/9422
if ((uint)i >= (uint)entries.Length)
{
Expand Down