Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing slash documentation fix #43

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Conversation

ayezinzu
Copy link
Collaborator

@ayezinzu ayezinzu commented Apr 2, 2024

Closes #42

Copy link
Member

@alexiglesias93 alexiglesias93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Please:

package.json Outdated Show resolved Hide resolved
Copy link
Member

@alexiglesias93 alexiglesias93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@ayezinzu
Copy link
Collaborator Author

ayezinzu commented Apr 2, 2024

@alexiglesias93 Issues resolved

Copy link
Member

@alexiglesias93 alexiglesias93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No updates to .npmrc are required...
Please get rid of it and the pnpm-lock.yaml updates.
Just run pnpm install

@ayezinzu
Copy link
Collaborator Author

ayezinzu commented Apr 2, 2024

No updates to .npmrc are required... Please get rid of it and the pnpm-lock.yaml updates. Just run pnpm install

image

@alexiglesias93 Doing so causes this error.

This is what I added the npmrc for

@ayezinzu
Copy link
Collaborator Author

ayezinzu commented Apr 2, 2024

No updates to .npmrc are required... Please get rid of it and the pnpm-lock.yaml updates. Just run pnpm install

image

@alexiglesias93 Doing so causes this error.

This is what I added the npmrc for

Removed npmrc and updated lockfile.

This fixes the CI error

@alexiglesias93

@alexiglesias93 alexiglesias93 merged commit 123d6c3 into master Apr 2, 2024
1 check passed
@alexiglesias93 alexiglesias93 deleted the documentation-fix branch April 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong description for removeTrailingSlash()
2 participants