Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct EnvVarSource type in vvp model #159

Merged
merged 2 commits into from
Jul 17, 2020
Merged

fix: correct EnvVarSource type in vvp model #159

merged 2 commits into from
Jul 17, 2020

Conversation

austince
Copy link
Contributor

The autogenerated VVP client uses the incorrect JsonNode type. For the EnvVar model, the core.EnvVarSource should be used instead.

Closes #151

@austince austince added apiVersion/v1beta1 The v1beta1 API apiVersion/v1beta2 The v1beta2 API go Pull requests that update Go code kind/bug Something isn't working labels Jul 17, 2020
@austince austince merged commit 890a986 into master Jul 17, 2020
@austince austince deleted the fix/vpdeployment/env-var-value-from branch July 17, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
apiVersion/v1beta1 The v1beta1 API apiVersion/v1beta2 The v1beta2 API go Pull requests that update Go code kind/bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VpDeployment EnvVars valueFrom reduced to {}
1 participant
@austince