Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support VVP 2.1.0 #92

Merged
merged 19 commits into from
Mar 14, 2020
Merged

feat: support VVP 2.1.0 #92

merged 19 commits into from
Mar 14, 2020

Conversation

austince
Copy link
Contributor

@austince austince commented Mar 14, 2020 •
edited
Loading

2.1.0 introduced a lot of change from the swagger definition side -- this restructures the entire project to introduce interfaces to that dependency.

Introduces many breaking changes:

  • StartFromSavepoint no longer an option on deployments
  • Deployment Targets no longer support a JSON patch list
  • Only one base VVP URL is needed now, instead of one for each the Platform and the AppManager APIs

Other changes:

  • Properly clean up pollers
  • Add mocks for testing
  • Upgrades various dependencies, including kind and controller-runtime
  • Adds support for Pod labels

Still left to do:

  • Support the Deployment Running status
  • Support Deployment Defaults

Closes #89
Closes #91

@austince austince added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code go Pull requests that update Go code kind/bug Something isn't working kind/feature New feature or request labels Mar 14, 2020
@austince austince added this to the v1 milestone Mar 14, 2020
@austince austince self-assigned this Mar 14, 2020
@austince austince merged commit d851dc1 into master Mar 14, 2020
@austince austince deleted the feat/vvp/2.1.0 branch March 14, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@austince austince

Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code go Pull requests that update Go code kind/bug Something isn't working kind/feature New feature or request
Milestone
v1
Development

Successfully merging this pull request may close these issues.
1 participant
@austince