This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
fix issue when multiple tx per block and calling getBlock. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these changes resolve the issue which was the kotlin sdk was throwing an error when there are multiple tx in a block, and getBlock is called.
added 5 commits
January 18, 2021 13:19
these changes serialize required fields for signing purposes, and do not serialize action objects for getBlock.
un-necessary for PR
un-necessary
make the getBlock call accessible, also note the test that was used to verify the function. This may be added to tests later but is hard to set up blcoks in the expected configurations to verify, so we verfieid visually.
ericbutz
approved these changes
Jan 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes resolve the issue which was the kotlin sdk was throwing an error when there are multiple tx in a block, and getBlock is called.
This PR adds some new data objects relating to the transaction so that there is more information returned from getBlock.