Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post No me acordaba que existía hasta que lo vi! #34

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

MJoaaquin
Copy link

No description provided.

@MJoaaquin MJoaaquin self-assigned this Jan 25, 2022
@JeronimoC23 JeronimoC23 self-requested a review January 25, 2022 12:56
@JeronimoC23 JeronimoC23 merged commit 1980b44 into main Jan 25, 2022
@JeronimoC23 JeronimoC23 deleted the no-me-acordaba-post branch January 25, 2022 13:23
Copy link
Member

@pbrudnick pbrudnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejo algunas sugerencias, si no queda nombre de funcion subtitulo 3 y abajo subtitulo 2 (mas importante) la firma. No estoy seguro si va a quedar muy bien.

Los iframe de jsfiddle funcionan?

Comment on lines +16 to +17
### grep
## function(elementoDelArray, indiceEnArray):array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### grep
## function(elementoDelArray, indiceEnArray):array
# grep
function(elementoDelArray, indiceEnArray):array

Comment on lines +25 to +26
### makeArray
## function(objeto):array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### makeArray
## function(objeto):array
# makeArray
function(objeto):array

Comment on lines +33 to +34
### noop
## function()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### noop
## function()
# noop
function()

Comment on lines +38 to +39
### unique
## function(array):array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### unique
## function(array):array
# unique
function(array):array


<iframe src="http://jsfiddle.net/bmCAR/1/embedded/" width="100%" height="300" frameborder="0" allowfullscreen="allowfullscreen"></iframe>

## Caso vivido para que tengan en cuenta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Caso vivido para que tengan en cuenta
# Caso vivido para que tengan en cuenta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants