fixed some issues with radians and angles #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The AgentClient actually doesn't specify degree or radius storage. But the referee use degree in it's inner computation. If the FIRASIM uses radius, it is better to convert it to degree. |
|
I belive using radius can be beneficial in cases of using mathematical functions and most libraries belive the input angle is in terms of the radius. So if it's can be fixed only by this PR and no further changes in the platform, I think we can apply it. @peng1999 what's your opinion about furthur changes in referee? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both FIRASIM and AgentClient use radians for storage, this update is to solve the problem