-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.lang.ClassNotFoundException: com.firebase.ui.auth.data.model.FlowParameters #1416
Comments
I just updated to Firebase UI 4.2 and I'm getting the same error. |
@dimipaun are you seeing this in both debug an production builds? Are you using ProGuard or R8 in either? |
Yes, I see them in both. And yes, we use ProGuard in both. I don't know about R8 though, how can I tell? I don't remember doing anything to enable it explicitly. |
Ah ok. Can you do two things for me then?
|
Of course, here's my ProGuard:
|
And I double checked, my bad -- we do NOT use ProGuard in debug builds. |
Looks like we need to manually set our class loader (that would make sense since flow params won't be in the boot class loader): FirebaseUI-Android/auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java Line 87 in a045fb9
|
Thanks @SUPERCILEX! So I guess this has to happen on the Firebase UI side - any thoughts on ETA? |
Absolutely! From what I understand, you basically want to add this to the line I linked to above: Do you feel up to submitting a PR? TBH, there's no way of checking if it actually works until you ship it, so as long as that line doesn't break stuff, SGTM. 👍 |
PR #1451 |
Bummer,
|
@dimipaun can you help us try to reproduce the issue? Would help to know:
It's totally crazy to me that you're the only one reporting this issue! For something as basic as this I'd expect everyone to be yelling :-/ |
Yes, of course!
Note, if there's only one element in the |
Dang! 😞 Can you reproduce it on an emulator or a non Samsung device? Or is it just that device? |
Let's try this solution instead: ArthurHub/Android-Image-Cropper#332 |
OK, working on it. |
…tFoundException during unmarshaling. See ArthurHub/Android-Image-Cropper#332
…tFoundException during unmarshaling. See ArthurHub/Android-Image-Cropper#332
PR #1453 |
@samtstern Let's hope that |
Arrgghhh:
|
Hmmm, same stacktrace, I wonder if I'm using the latest changes.... |
@dimipaun if you want to be triple sure:
Then you can't be possibly running old code! |
Hi @samtstern @SUPERCILEX on closer inspection, the code doesn't reach our activity, look at the stacktrace:
so whatever we add in:
will not work, right? Am I missing something? Would it make sense to
maybe we do:
Thoughts? |
Go for it! 👍 Though it would be nice if you could test it locally first. 😊 |
I'd love to test locally, but frankly I haven't figured out how to build it and then use in the app. |
Where are you getting stuck? What error? |
This is because the exception happens _before_ we get to read the FlowParameters from the extras/bundle.
I got the same error
Tested on multiple devices. Model SM-N910 |
@SzasznikaJanos are you able to reproduce this easily? If so steps would be really helpful! |
I got the same error. Adding this line fixed it:
Model SM-G930F |
Step 1:
When trying to get the Auth UI going:
I see the following behaviour:
idpConfigs
contains exactly one item, it correctly proceeds to the one login methodidpConfigs
contains more than one item, theAuthMethodPickerActivity
is displayed WITHOUT any of the login buttons (but it correctly shows the ToS/PP at the bottom)Looking through the logs, I see this error:
Which would explain the issue. Here's the relevant snippet of my build.gradle:
This used to work, but I guess it broke with a recent update of FirebaseUI.
Step 2: Describe your environment
The text was updated successfully, but these errors were encountered: