Creating a Firebase SpinnerAdapter

[WillieCubed]

During a project I've been working on, I have created a SpinnerAdapter modeled after the FirebaseListAdapter, and I was going to submit a pull request until I saw something about submitting an issue request about any changes wanting to be made. Simply put, can I submit a PR containing a SpinnerAdapter that recieves data from a DatabaseReference or Query? I've seen another PR that messed with FirebaseArray, but it doesn't seem like it conflicts.

Thanks.

[puf]

What does this adapter change about the existing behavior?
Will you also be submitting a corresponding PR for FirebaseUI-iOS?

On Tue, Sep 13, 2016 at 4:58 PM Willie Chalmers III <
notifications@github.com> wrote:

During a project I've been working on, I have created a SpinnerAdapter
modeled after the FirebaseListAdapter, and I was going to submit a pull
request until I saw something about submitting an issue request about any
changes wanting to be made. Simply put, can I submit a PR containing a
SpinnerAdapter that recieves data from a DatabaseReference or Query? I've
seen another PR that messed with FirebaseArray, but it doesn't seem like it
conflicts.

Thanks.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#304, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA3w38DQmu1XuTtaVEBAJCefiEZsudNrks5qpzicgaJpZM4J8RP-
.

[WillieCubed]

It adds the functionality to specify a dropdown view along with the standard view it shows when not selected. I will if submit a PR for this in FirebaseUI-iOS if this isn't too redundant.

[puf]

Sorry, I'm still not very clear on what this does. The goal of submitting
an issue before a PR is so that we can discuss the feature and its merits
first.

What is the goal of the dropdown view? Is it being populated from a
FirebaseArray?

Given that you have this working in an existing project: a screenshot might
clarify this more quickly.

On Tue, Sep 13, 2016 at 5:13 PM Willie Chalmers III <
notifications@github.com> wrote:

It adds the functionality to specify a dropdown view along with the
standard view it shows when not selected. I will if submit a PR for this in
FirebaseUI-iOS if this isn't too redundant.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#304 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3w31I7-7pEosTyAqV6k96-bULqXOZMks5qpzwbgaJpZM4J8RP-
.

[WillieCubed]

Sorry for the wait.

The FirebaseSpinnerAdapter is populated the same way the other adapters are being populated, i.e., creating a FirebaseArray with a given Query or DatabaseReference.

I'm essentially proposing this

and this

populated by this:

I created another adapter to give more freedom of implementation and I currently get this effect if I use a FirebaseListAdapter:

[WillieCubed]

Does this feature seem worthy enough to submit a PR for?

[puf]

Hey @TheCraftKid . The screenshots and data structure indeed help. It looks like it could work. So far we've intentionally kept the number of components/adapters in the library low, so that we can focus on getting the core functionality right. I'd like to stay that course for a bit longer.

But your component sounds like a great separate library, that could then internally use FirebaseUI. That would also solve the problem that FirebaseUI requires that we offer the functionality on both iOS and Android, which is holding a lot of other PRs back.

Can you try putting the component(s) into a separate library that uses FirebaseUI? It would be a good test-case for our extensibility model.

[WillieCubed]

Sorry for prematurely submitting the PR. I'll take that suggestion, though. Thank you!

[puf]

No problem. I read the issue first and only then saw that your PR was
already doing what I proposed. Looks like a nice, simple, clean UI
component, so is great proof that you can build upon FirebaseUI. A separate
repo would be a great place to keep other custom components.

On Sat, Sep 17, 2016 at 7:55 PM Willie Chalmers III <
notifications@github.com> wrote:

Closed #304 #304.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#304 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3w37lZeJLGqWlsw5lSu2BgWn6vPtVNks5qrKgMgaJpZM4J8RP-
.