Add support for Play Games provider #1211
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/util/data/ProviderUtils.java
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
@samtstern Do you want to take a look at this one? I'm gonna be honest, I couldn't get it to work, see #1211 (comment). |
|
@SUPERCILEX I'll see if I can get games sign in going. |
|
@SUPERCILEX update: I did look at this but I am also having a hell of a time actually getting set up with Play Games ... and I used to work on that product! |
| @LayoutRes int buttonLayout; | ||
| switch (idpConfig.getProviderId()) { | ||
| case GoogleAuthProvider.PROVIDER_ID: | ||
| case PlayGamesAuthProvider.PROVIDER_ID: |
There was a problem hiding this comment.
I think we want to have a green "Sign in with Play games" button. I'll see if I can get us the assets.
|
Got some assets for you, let me know if we need different ones.
|
|
Sweet, thanks for the assets! And yeah, let me know if you ever find someone who's able to get Play Games sign-in to work 😂 |
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
…both Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
@samtstern We're also going to need translations, I'll let you get that started. 😊 |
…ames # Conflicts: # library/quality/quality.gradle
|
@SUPERCILEX offended if I kick this and Github to |
|
Not at all! That makes sense to me. 👍 |
|
I still can't get PGS sign in to work ... so bumping to 4.2.0. Sorry @SUPERCILEX I know you worked hard on this! |
|
Haha, well if no one can get this working, maybe you could find someone who worked on it and show us how it's done. 😁 |
|
Any luck getting help from an insider? Years ago I was trying to implement GCM device group messaging and after following the documentation to the letter it just wouldn't work. Many months later a Googler replied on Stack Overflow (or similar) and revealed that the request needs an undocumented parameter, and then it finally worked. I get the feeling this is a similar situation. |
|
Still having no luck here. My attempts fail with an error in the developer console, and a lot of times in those cases being an insider is the problem not the solution. |
|
Sigh. Booting this from the milestone again. |
|
@SUPERCILEX going to close this old PR so that there's not confusion like there was on #309 |
|
Sounds good! |
3 participants
More work on #1196.
For some reason, I just can't get login to work with Play Games. I'm always getting error code 12501 and logs like this:
GamesAuthenticator: Must have a game ID to sign in!. Normal Google sign-in works just fine and I've tried hardcoding the client id, messing with SHA1 certificates, everything! Could you perhaps try it with your setup to see if it's just me? 🤔