Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TwitterSignInHandler because its dependency TwitterKit is deprecated #1627

Closed

Conversation

efrohnhoefer
Copy link

Closes: #1626

@efrohnhoefer efrohnhoefer requested a review from samtstern as a code owner April 29, 2019 20:55
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@samtstern
Copy link
Contributor

@efrohnhoefer thanks for sending this PR! I appreciate the effort however this is not the route we are going to take with Twitter. First we need to re-implement this on top of the "Generic IDP" flow (@lsirac can comment) and then we can remove this.

@samtstern
Copy link
Contributor

This was fixed by @lsirac in #1714

@samtstern samtstern closed this Dec 16, 2019
@samtstern samtstern added this to the 6.2.0 milestone Dec 16, 2019
@efrohnhoefer efrohnhoefer deleted the efrohnhoefer/delete_twitter branch December 19, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TwitterSignInHandler because its dependency TwitterKit is deprecated.
3 participants