-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(firestore): migrate pagination to Paging 3 #1915
Merged
samtstern
merged 28 commits into
firebase:version-8.0.0-dev
from
thatfiredev:rpf-migrate-firestore-paging-3
Jun 28, 2021
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
3677ec5
refactor: pass an Activity instead of an Executor to verifyPhone
thatfiredev 15165cd
chore: update Firebase BoM to 26.0.0
thatfiredev 540d94f
refactor: use the new PhoneAuthOptions from auth v20.0.0
thatfiredev 5f7bc1b
refactor(firestore): replace FirestoreDataSource with FirestorePaging…
thatfiredev 96aeabf
deprecated setQuery(PagedList.Config) in favor of setQuery(PagingConfig)
thatfiredev 589375a
fix: prevent the paging source from doing infinite scroll
thatfiredev b30e486
create FirestorePagingDataAdapter (for paging 3 support)
thatfiredev b70ccf3
deprecate setData() in favor of setPagingData()
thatfiredev 72f977e
remove loading and error states liveData in favor of new loadState li…
thatfiredev 7888e33
keep loading and error states in pagingSource for paging 2
thatfiredev 1071042
deprecate FirestorePagingAdapter in favor of FirestorePagingDataAdapter
thatfiredev 1515a56
test: update FirestorePagingSourceTest (previously FirestoreDataSourc…
thatfiredev 46f07dc
add @NonNull to FirestorePagingSource constructor arguments
thatfiredev 6d4e326
fix checkstyle errors
thatfiredev c9479d8
fix NonNull and Nullable annotations
thatfiredev 91f6269
re-add FirestorePagingAdapter.retry() for paging 2
thatfiredev 3c8687a
remove FirestorePagingSource and consequently Java 8
thatfiredev cb2b4b5
undo unecessary changes
thatfiredev fa5f998
Merge branch 'master' of https://github.com/firebase/FirebaseUI-Andro…
thatfiredev 3a1b54e
refactor: make this a breaking change
thatfiredev 610ac14
test: delete FirestoreDataSourceTest.java
thatfiredev 824639e
remove unused imports from FirestorePagingAdapter
thatfiredev b7043aa
chore: update paging library to beta03
thatfiredev 86bab6a
docs: update firestore/README.md
thatfiredev 4e26689
chore: update paging to 3.0.0 (stable)🥳
thatfiredev 0df2cb2
Merge branch 'version-8.0.0-dev' into rpf-migrate-firestore-paging-3
samtstern 8f1672b
chore(firestore): migrate to java 8 and add Paging RxJava
thatfiredev 5f101cd
refactor: replace FirestoreDataSource with Firestore Paging 3
thatfiredev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing
Function1<>
🤮 reminds me that we can probably convert the sample app to Kotlin once we go to 8.0!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely should!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samtstern actually, since we migrated to Java 8, this can actually be replaced with a lambda function:
So we don't really need
Function1<>
here. 😅