feat: add support for MFA challenge during sign in #2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
reviewed
Oct 22, 2025
| onSuccess = { | ||
| pendingResolver.value = null | ||
| // Reset auth state to Idle so the firebaseAuthFlow Success state takes over | ||
| authUI.updateAuthState(AuthState.Idle) |
There was a problem hiding this comment.
should we be able to updateAuthState from outside FirebaseAuthUI class?
There was a problem hiding this comment.
I don't think we should allow that, either the user is using it properly, or not 🤔
Can be discussed in a future release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for MFA challenge during sign in.
Will catch the error and update internal state appropriately.