feat: Google Sign-In (GoogleSignInHandler) #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unit tests covering google sign in, anonymous upgrade and error states - updated google auth dependencies
Lyokone
reviewed
Oct 24, 2025
| try { | ||
| signInWithGoogle(context, config, provider) | ||
| } catch (e: AuthException) { | ||
| // Log.d("rememberGoogleSignInHandler", "exception: $e") |
Lyokone
reviewed
Oct 24, 2025
| authorizationProvider.authorize(context, requestedScopes) | ||
| // Log.d("GoogleSignIn", "Successfully authorized scopes: ${provider.scopes}") | ||
| } catch (e: Exception) { | ||
| // Log.w("GoogleSignIn", "Failed to authorize scopes: ${provider.scopes}", e) |
Lyokone
reviewed
Oct 24, 2025
Comment on lines
192
to
194
| // Log.d("GoogleSignIn", "Cleared Google credential state") | ||
| } catch (e: Exception) { | ||
| // Log.w("GoogleSignIn", "Failed to clear credential state", e) |
Lyokone
reviewed
Oct 24, 2025
| class MainActivity : ComponentActivity() { | ||
| companion object { | ||
| private const val USE_AUTH_EMULATOR = true | ||
| private const val USE_AUTH_EMULATOR = false |
There was a problem hiding this comment.
we can keep that to true by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PENDING:
sign_in_with_google.webm